Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add stubs for documentation #17

Merged
merged 1 commit into from
Sep 19, 2023
Merged

DOC: add stubs for documentation #17

merged 1 commit into from
Sep 19, 2023

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Sep 1, 2023

Adds the infrastructure for building documentation. Can currently only be built locally, as the repository is still private, but will eventually be built on ReadTheDocs.

Closes: #4
Reviewed-by: Nicolas Tessore

@paddyroddy paddyroddy changed the title Add readthedocs documentation DOC: Add readthedocs documentation Sep 1, 2023
@ntessore
Copy link
Contributor

ntessore commented Sep 1, 2023

RTD now integrated with this repo, with builds for PRs enabled. Should work on next push to this branch.

@paddyroddy
Copy link
Member Author

@ntessore private repos not supported, so guess we'll have to wait on this
image

@ntessore
Copy link
Contributor

ntessore commented Sep 1, 2023

Ah, sure. I will disable PR builds on RTD. We can still build locally and as part of CI.

@paddyroddy
Copy link
Member Author

So I'm going to leave this for now. Essentially, what I've done is make a start on the documentation - with a focus on the API documentation. For ease, I'm incorporating everything public from the heracles module (although, of course, we can selectively choose with mkdocstrings). As a result, I've made things private which shouldn't be called by an external user.

I've also added docstrings to all functions/classes/modules. So in general you'll see a lot of _description_ and _summary_ placeholders. I haven't time/knowledge to fix each of those.

I've gone through and added typing to the best of my ability. For those where I've been unsure I've put typing.TypeVar("Unknown") as a placeholder - I decided not to use typing.Any as that disables type checking, and in general we want that.

I looked into adding the notebook as a standalone page using mkdocs-jupyter, but the plugin seems to no longer work.

I've decided to use MkDocs rather than sphinx as an experiment. It should mean you can just write markdown files in the docs folder and everything should work out the box. MkDocs has a similar plugin ecosystem to sphinx.

I've also included the README.md as the main index.html of the website. I've added some markdown badges to the README.md as well, to let others know what the code is about.

@paddyroddy paddyroddy self-assigned this Sep 14, 2023
@paddyroddy paddyroddy added the documentation Improvements or additions to documentation label Sep 14, 2023
@paddyroddy paddyroddy requested a review from ntessore September 14, 2023 13:52
@paddyroddy paddyroddy linked an issue Sep 14, 2023 that may be closed by this pull request
@ntessore ntessore changed the title DOC: Add readthedocs documentation DOC: add stubs for documentation Sep 19, 2023
Copy link
Contributor

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as separate commits for the docs infrastructure and content changes.

@ntessore ntessore merged commit 2aef719 into main Sep 19, 2023
7 checks passed
@ntessore ntessore deleted the add-docs branch September 19, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialise Sphinx documentation
2 participants